Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TracerFactory #114

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Implement TracerFactory #114

merged 1 commit into from
Oct 9, 2019

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Oct 8, 2019

Partial fix for #113

mwear
mwear approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I am still pretty unsure about the concept of named tracers, and how the interaction between multiple tracers will play out in the real world, but that has nothing to do with this work specifically.

@fbogsany fbogsany merged commit 3265f5a into open-telemetry:master Oct 9, 2019
@fbogsany fbogsany deleted the tracer-factory branch October 9, 2019 18:25
@dyladan dyladan mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@bai bai Awaiting requested review from bai

@luvtechno luvtechno Awaiting requested review from luvtechno

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbogsany @mwear